Skip to content

Bugfix for FluxWeight and MeVPrtl #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
VCLanNguyen wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Bugfix for FluxWeight and MeVPrtl #621

VCLanNguyen wants to merge 3 commits into from
+3 −3

Conversation

@VCLanNguyen
Copy link
Contributor

@VCLanNguyen VCLanNguyen commented Jan 9, 2026 •
edited
Loading

  1. Fix a bug in MeVPrtl: BNBKaonGen incorrectly label boone ntuple as dk2nu format. Updated to it simple flux format. This would prevent Flux Weight tools to to crash when inputting MeVPrtl files.
  2. Add a feature in Flux Weight tools: to pick up neutrino energy from MCTruth instead if flux.nenergyn == -1.
    In MeVPrtl, by default, MCFlux neutrino energy is filled as -1 since not every meson in flux file would result in a neutrino. It instead computes an equivalent neutrino energy and saves it as MCTruth.
    This change should not impact the neutrino workflow since every meson results in a neutrino, and MCFlux flux.nenergyn should always be filled.

Description

Please provide a detailed description of the changes this pull request introduces. If available, also link to a docdb link where the issue/change have been presented on/discussed.

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@VCLanNguyen
bugfix MeVPrtl to classify boone ntuple flux type as simple flux, and…
0f08627 
… fix flux weight calculator to pick neutrino energy from MCTruth if MCFlux energy is -1
@VCLanNguyen VCLanNguyen self-assigned this Jan 9, 2026
@VCLanNguyen VCLanNguyen added the bugfix Addresses one or more bugs label Jan 9, 2026
@kjplows kjplows moved this to Open pull requests in SBN software development Jan 15, 2026
@linyan-w linyan-w moved this to Waiting on Reviewer in SBND 2025 Fall Production Jan 22, 2026
@kjplows kjplows moved this from Open pull requests to Partially reviewed in SBN software development Jan 26, 2026
jicrespo
jicrespo reviewed Jan 27, 2026
View reviewed changes
Copy link
Member

@jicrespo jicrespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments below.

@kjplows
Copy link
Contributor

kjplows commented Jan 28, 2026

Hi @jicrespo and @VCLanNguyen , is this branch ready for CI? Thanks

@kjplows
Copy link
Contributor

kjplows commented Jan 28, 2026

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_02_01 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbncode@v10_14_02_01 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_01

@kjplows kjplows moved this from Partially reviewed to Testing in SBN software development Jan 28, 2026
@FNALbuild
Copy link

FNALbuild commented Jan 28, 2026

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

FNALbuild commented Jan 28, 2026

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

FNALbuild commented Jan 28, 2026

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

FNALbuild commented Jan 28, 2026

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

FNALbuild commented Jan 28, 2026

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

FNALbuild commented Jan 28, 2026

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gputnam gputnam gputnam approved these changes

@jicrespo jicrespo jicrespo approved these changes

@JosiePaton JosiePaton JosiePaton approved these changes

Assignees

@VCLanNguyen VCLanNguyen

Labels

bugfix Addresses one or more bugs

Projects

SBN software development
Status: To merge
SBND 2025 Fall Production
Status: Waiting on Reviewer

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@VCLanNguyen @kjplows @FNALbuild @gputnam @jicrespo @JosiePaton